From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: minor fixes after pgindent prototype fixes |
Date: | 2019-07-29 18:47:12 |
Message-ID: | 20190729184712.GA19415@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2019-Jul-28, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > a few prototypes look odd. It appears to be cases where previously the
> > odd indentation was put to some use, by indenting parameters less:
> > ...
> > but now that looks odd:
> > extern void DefineCustomBoolVariable(
> > const char *name,
> > const char *short_desc,
>
> > Unless somebody protests I'm going to remove the now pretty useless
> > looking newline in the cases I can find.
>
> +1. I think Alvaro was muttering something about doing this,
> but you beat him to it.
No, this is a different issue ... I was talking about function *calls*
ending in parens, and it changed because of the previous round of
pgindent changes, not the last one. The number of affected places was a
lot larger than the patch Andres posted.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2019-07-29 18:47:56 | Re: POC: Cleaning up orphaned files using undo logs |
Previous Message | Tom Lane | 2019-07-29 18:27:02 | Re: Proposal for Signal Detection Refactoring |