Re: Race conditions with TAP test for syncrep

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Race conditions with TAP test for syncrep
Date: 2019-07-23 08:04:32
Message-ID: 20190723080432.GE2059@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jul 22, 2019 at 11:45:53PM -0700, Noah Misch wrote:
> PostgresNode uses "print" the same way. The patch does close the intended
> race conditions, and its implementation choices look fine to me.

Thanks Noah for the review. I have reviewed the thread and improved a
couple of comments based on Alvaro's previous input. Attached is v2.
If there are no objections, I would be fine to commit it.
--
Michael

Attachment Content-Type Size
syncrep-stability-v2.patch text/x-diff 3.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-07-23 08:10:23 Re: [PATCH] minor bugfix for pg_basebackup (9.6 ~ )
Previous Message Fabien COELHO 2019-07-23 07:44:09 Re: pgbench - add pseudo-random permutation function