Re: Race conditions with TAP test for syncrep

From: Noah Misch <noah(at)leadboat(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Race conditions with TAP test for syncrep
Date: 2019-07-23 06:45:53
Message-ID: 20190723064553.GA2008253@rfd.leadboat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jun 18, 2019 at 09:59:08AM +0900, Michael Paquier wrote:
> On Mon, Jun 17, 2019 at 10:50:39AM -0400, Alvaro Herrera wrote:
> > I think this should be note() rather than print(), or maybe diag(). (I
> > see that we have a couple of other cases which use print() in the tap
> > tests, which I think should be note() as well.)
>
> OK. Let's change it for this patch.

PostgresNode uses "print" the same way. The patch does close the intended
race conditions, and its implementation choices look fine to me.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ning Yu 2019-07-23 06:54:20 Re: Possible race condition in pg_mkdir_p()?
Previous Message Peter Eisentraut 2019-07-23 06:12:12 Re: initdb recommendations