Re: Compiler warnings with MinGW

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>
Subject: Re: Compiler warnings with MinGW
Date: 2019-07-20 09:19:34
Message-ID: 20190720091934.GD1768@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jul 19, 2019 at 08:41:28AM -0400, Andrew Dunstan wrote:
> On 7/19/19 1:08 AM, Michael Paquier wrote:
>> The second one is rather obvious to fix, because we don't care about
>> the file mode on Windows, so the attached should do the work. I am
>> actually surprised that the Visual Studio compilers don't complain
>> about that, but let's fix it.
>>
>> Thoughts?
>
> +1.

Just wanted to double-check something. We usually don't bother
back-patching warning fixes like this one, right?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michail Nikolaev 2019-07-20 12:35:57 thoughts on "prevent wraparound" vacuum
Previous Message Michael Paquier 2019-07-20 09:17:33 Re: pgsql: Sync our copy of the timezone library with IANA release tzcode20