| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Custom table AMs need to include heapam.h because of BulkInsertState |
| Date: | 2019-07-18 01:20:18 |
| Message-ID: | 20190718012018.gqggvy2jodasdoyj@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2019-07-18 11:57:44 +1200, David Rowley wrote:
> However, I spent quite a bit of time trying to make that function as
> fast as possible in v12, and since #2 seems like a perfectly good
> alternative, I'd rather go with that than to add pollution to
> ExecFindPartition's signature. Also, #2 seems better since it keeps
> CopyFrom() from having to maintain a list. I think we all agreed
> somewhere that that code is more complex than we'd all like it to be.
Fair enough.
One last thought for #1: I was wondering about is whether a the bool *
approach might be useful for nodeModifyTable.c too? I thought that maybe
that could be used to avoid some checks for setting up per partition
state, but it seems not to be the case ATM.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2019-07-18 01:22:34 | Re: Add client connection check during the execution of the query |
| Previous Message | Andres Freund | 2019-07-18 01:16:32 | Re: refactoring - share str2*int64 functions |