| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Ramanarayana <raam(dot)soft(at)gmail(dot)com>, Prajwal A V <prajwal450(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Contribution to Perldoc for TestLib module in Postgres |
| Date: | 2019-07-10 07:33:16 |
| Message-ID: | 20190710073316.GD5042@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 09, 2019 at 03:16:01PM +0200, Daniel Gustafsson wrote:
> The v2 patch is somewhat confused as it has Windows carriage returns rather
> than newlines, so it replaces the entire file making the diff hard to read. It
> also includes a copy of TestLib and the v1 patch and has a lot of whitespace
> noise.
Nobody can provide a clear review if the files are just fully
rewritten even based on a read of the patch. Perhaps you are working
on Windows and forgot to configure core.autocrlf with "git config".
That could make your life easier.
I have switched the patch as "waiting on author" for now.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2019-07-10 07:35:18 | Re: Excessive memory usage in multi-statement queries w/ partitioning |
| Previous Message | Michael Paquier | 2019-07-10 07:28:04 | Re: Two pg_rewind patches (auto generate recovery conf and ensure clean shutdown) |