Re: BUG #15888: Bogus "idle in transaction" state for logical decoding client after creating a slot

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, marko(at)joh(dot)to, pgsql-bugs(at)lists(dot)postgresql(dot)org, Magnus Hagander <magnus(at)hagander(dot)net>
Subject: Re: BUG #15888: Bogus "idle in transaction" state for logical decoding client after creating a slot
Date: 2019-07-09 21:46:30
Message-ID: 20190709214630.GA15632@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-bugs

On 2019-Jul-09, Andres Freund wrote:

> The problem doesn't exist in later versions, because there
> exec_replication_command() does an explicit
> /* Report to pgstat that this process is now idle */
> pgstat_report_activity(STATE_IDLE, NULL);
> That's due to
> commit d02974e32e028fc078d8f5eca1d6a4516efb0aa6
> Author: Magnus Hagander <magnus(at)hagander(dot)net>
> Date: 2017-12-29 16:19:51 +0100
> Properly set base backup backends to active in pg_stat_activity
> which is post 9.6. Not sure I really feel a huge appetite for whacking
> this around in the back branches.

Hmm ... so what that commit did is precisely to fix this bug.
Magnus thought at the time he was fixing a pg10 bug,
but apparently now we see that the bug was older than that. Maybe it's
okay to backpatch further?

(Booh to missing "Discussion:" tags in commit messages)

Álvaro Herrera
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to


Browse pgsql-bugs by date

  From Date Subject
Next Message Thomas Munro 2019-07-09 22:43:28 Re: BUG #15900: `executor could not find named tuplestore` in triggers with transition table and row locks
Previous Message Alvaro Herrera 2019-07-09 21:26:16 Re: BUG #15752: Declarative partitions trigger with function attributes - empty attributes list on each partition