From: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
---|---|
To: | Patrick McHardy <kaber(at)trash(dot)net> |
Cc: | pgsql-hackers(at)postgresql(dot)org, alvherre(at)alvh(dot)no-ip(dot)org |
Subject: | Re: [PATCH] Fix trigger argument propagation to child partitions |
Date: | 2019-07-09 16:59:15 |
Message-ID: | 20190709165915.cmoucycya3qecznv@development |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Jul 09, 2019 at 03:00:27PM +0200, Patrick McHardy wrote:
>The following patch fixes propagation of arguments to the trigger
>function to child partitions both when initially creating the trigger
>and when adding new partitions to a partitioned table.
>
Thanks for the report and bugfix. It seeem the parameters in row triggers
on partitioned tables never worked :-( For a moment I was wondering why it
shows on 11 and not 10 (based on the assumption you'd send a patch against
10 if it was affected), but 10 actually did not support row triggers on
partitioned tables.
The fix seems OK to me, although I see we're parsing tgargs in ruleutils.c
and that version (around line ~1050) uses fastgetattr instead of
heap_getattr, and checks the isnull parameter after the call. I guess we
should do the same thing here.
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Jesper Pedersen | 2019-07-09 17:18:52 | Re: pg_receivewal documentation |
Previous Message | Paul A Jungwirth | 2019-07-09 16:40:59 | Re: range_agg |