From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
Cc: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: doc: improve PG 12 to_timestamp()/to_date() wording |
Date: | 2019-07-09 03:04:19 |
Message-ID: | 20190709030419.r5xwhuoxkrepvjnq@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, Jul 6, 2019 at 03:24:25PM -0500, Justin Pryzby wrote:
> On Tue, Apr 30, 2019 at 07:14:04PM -0500, Justin Pryzby wrote:
> > On Tue, Apr 30, 2019 at 09:48:14PM +0300, Alexander Korotkov wrote:
> > > I'd like to add couple of comments from my side.
> >
> > > > - returns an error because the second template string space is consumed
> > > > - by the letter <literal>J</literal> in the input string.
> > > > + returns an error because the second space in the template string consumes
> > > > + the letter <literal>M</literal> from the input string.
> > >
> > > Why <literal>M</literal>? There is no letter "M" is input string.
> > > The issue here is that we already consumed "J" from "JUN" and trying
> > > to match "UN" to "MON". So, I think we should live
> > > <literal>J</literal> here. The rest of this change looks good.
> >
> > Seems like I confused myself while resolving rebase conflict.
> >
> > Thanks for checking.
>
> Find attached updated patch, which seems to still be needed.
>
> This was subsumed and now extracted from a larger patch, from which Michael at
> one point applied a few hunks.
> I have some minor updates based on review from Andres, but there didn't seem to
> be much interest so I haven't pursued it.
> https://www.postgresql.org/message-id/20190520182001.GA25675%40telsasoft.com
Patch applied back through PG 12. Thanks.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas Munro | 2019-07-09 03:04:27 | Re: PGOPTIONS="-fh" make check gets stuck since Postgres 11 |
Previous Message | Michael Paquier | 2019-07-09 02:58:56 | Re: Postgres 11: Table Partitioning and Primary Keys |