| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: PGOPTIONS="-fh" make check gets stuck since Postgres 11 |
| Date: | 2019-07-09 01:31:05 |
| Message-ID: | 20190709013105.GA1345@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jul 08, 2019 at 03:21:41PM -0400, Tom Lane wrote:
> Having said that, join_hash.sql in particular seems to have zero
> value if it's not testing hash joins, so I think it'd be reasonable
> for it to override a global enable_hashjoin = off setting. None of
> the other regression test scripts seem to take nearly as much of a
> performance hit from globally forcing poor plans.
I am a bit confused here. Don't you mean to have enable_hashjoin =
*on* at the top of hash_join.sql instead like in the attached?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| hash-join-fix.patch | text/x-diff | 935 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2019-07-09 01:37:03 | Re: [PATCH] Incremental sort (was: PoC: Partial sort) |
| Previous Message | Bruce Momjian | 2019-07-09 01:29:17 | Re: [PATCH v4] Add \warn to psql |