| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Dmitry Belyavsky <beldmit(at)gmail(dot)com> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Nikolay Shaplov <dhyan(at)nataraj(dot)su>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Ltree syntax improvement |
| Date: | 2019-07-08 20:16:34 |
| Message-ID: | 20190708201634.GA17499@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-Jul-08, Dmitry Belyavsky wrote:
> Dear Thomas,
>
> Thank you for your proofreading!
>
> Please find the updated patch attached. It also contains the missing
> escaping.
I think all these functions you're adding should have a short sentence
explaining what it does.
I'm not really convinced that we need this much testing. It seems a bit
excessive. Many of these very focused test SQL lines could be removed
with no loss of coverage, and many of the others could be grouped into
one.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dmitry Belyavsky | 2019-07-08 20:21:42 | Re: Ltree syntax improvement |
| Previous Message | Tomas Vondra | 2019-07-08 19:59:35 | Re: [Proposal] Table-level Transparent Data Encryption (TDE) and Key Management Service (KMS) |