Re: [PATCH][PROPOSAL] Add enum releation option type

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Nikolay Shaplov <dhyan(at)nataraj(dot)su>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH][PROPOSAL] Add enum releation option type
Date: 2019-07-03 21:18:48
Message-ID: 20190703211848.GA17240@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2019-Jul-03, Nikolay Shaplov wrote:

> В письме от понедельник, 1 июля 2019 г. 14:06:28 MSK пользователь Alvaro
> Herrera написал:

> > + GistBufferingValidMsg = gettext_noop("Valid values are \"on\", \"off\",
> > and \"auto\".");
> >
> > I think that's the most contentious point on this patch at this point
> > (though I may be misremembering).
> I actually removed "and" from the list and let it be simple coma separated
> list
> ERROR: invalid value for "check_option" option
> DETAIL: Valid values are: "local", "cascaded".
> Now we can translate left part, and subst list to the right part

Yes, I saw that, and you know what? Nobody said they liked this idea.

> You do not see it that way?

I think this is easier to sell if you change that.

Álvaro Herrera
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Melanie Plageman 2019-07-03 21:22:09 Re: Avoiding hash join batch explosions with extreme skew and weird stats
Previous Message James Coleman 2019-07-03 21:02:44 Re: Index Skip Scan