Re: TopoSort() fix

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Rui Hai Jiang <ruihaij(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: TopoSort() fix
Date: 2019-07-03 07:11:31
Message-ID: 20190703071131.GE3084@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jul 03, 2019 at 10:41:59AM +0800, Rui Hai Jiang wrote:
> Could the attached patch fix this issue? Or does any one else plan to fix
> it?
>
> If people are busy and have not time, I can go ahead to fix it. To fix
> this issue, do we need a patch for each official branch?

Only a committer could merge any fix you produce. What you have sent
looks fine to me, so let's wait for Robert, who has visiblu broken
this part to comment. Back-patched versions are usually taken care of
by the committer merging the fix, and by experience it is better to
agree about the shape of a patch on HEAD before working on other
branches. Depending on the review done, the patch's shape may change
slightly...
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Oleksandr Shulgin 2019-07-03 07:29:32 Re: POC: converting Lists into arrays
Previous Message Fabien COELHO 2019-07-03 07:05:28 Re: [PATCH v4] Add \warn to psql