Re: Refactoring base64 encoding and decoding into a safer interface

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Refactoring base64 encoding and decoding into a safer interface
Date: 2019-07-02 08:22:29
Message-ID: 20190702082229.GA2836@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jul 02, 2019 at 09:56:03AM +0200, Daniel Gustafsson wrote:
> I’m not sure we need to go to that length, but I don’t have overly strong
> opinions. I think of this more like a case of “we’ve changed the API with new
> errorcases that we didn’t handle before, so we’re being a little defensive to
> help you avoid subtle bugs”.

I quite like this suggestion.

> Looks good, passes tests, provides value to the code. Bumping this to ready
> for committer as I no more comments to add.

Thanks. I'll look at that again in a couple of days, let's see if
others have any input to offer.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2019-07-02 08:28:04 Re: Add parallelism and glibc dependent only options to reindexdb
Previous Message Julien Rouhaud 2019-07-02 08:16:22 Re: Add parallelism and glibc dependent only options to reindexdb