Re: check_recovery_target_lsn() does a PG_CATCH without a throw

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: check_recovery_target_lsn() does a PG_CATCH without a throw
Date: 2019-06-30 12:35:52
Message-ID: 20190630123552.GB2286@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Jun 30, 2019 at 11:06:58AM +0200, Peter Eisentraut wrote:
> I ended up rewriting this by extracting the parsing code into
> pg_lsn_in_internal() and having both pg_lsn_in() and
> check_recovery_target_lsn() calling it. This mirrors similar
> arrangements in float.c

The refactoring looks good to me (including what you have just fixed
with PG_RETURN_LSN). Thanks for considering it.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Lakhin 2019-06-30 13:06:47 Fix typos and inconsistencies for HEAD
Previous Message Julien Rouhaud 2019-06-30 09:45:47 Add parallelism and glibc dependent only options to reindexdb