| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: tableam: abstracting relation sizing code |
| Date: | 2019-06-11 23:17:36 |
| Message-ID: | 20190611231736.xibq4f5v7ewdctjf@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2019-06-10 15:35:18 -0400, Robert Haas wrote:
> On Fri, Jun 7, 2019 at 6:42 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> > > Good catch, and now I notice that the callback is not called
> > > estimate_rel_size but relation_estimate_size. Updated patch attached;
> > > thanks for the review.
> >
> > The commit message still refers to it as estimate_rel_size though. The comment on
> > table_block_relation_estimate_size does too but that one might be intentional.
>
> Oops. New version attached, hopefully fixing those and the compiler
> warning Alvaro noted.
Just to understand: What version are you targeting? It seems pretty
clearly v13 material to me?
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2019-06-11 23:24:32 | Re: pgbench rate limiting changes transaction latency computation |
| Previous Message | Alvaro Herrera | 2019-06-11 23:13:43 | Re: [PATCH] Speedup truncates of relation forks |