| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | clemens(at)ladisch(dot)de, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #15833: defining a comment on a domain constraint fails with wrong OID |
| Date: | 2019-06-10 06:28:55 |
| Message-ID: | 20190610062855.GE2199@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Fri, Jun 07, 2019 at 02:42:33PM +0900, Michael Paquier wrote:
> Well, it wouldn't be a problem to do a syscache lookup and then use
> the type from contypid, no? It seems to me that it would be more
> consistent to just add a pg_domain_constraint_ownercheck() in aclchk.c
> as all the syscache lookups happen their for all the other objects
> types. What do you think?
Attached is what I have in mind. There are already tests at the
bottom of constraints.source checking for comments on both table and
domain constraints, so my proposal is to run them with a dedicated
role. What do you think?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| dom-constraint-comments-v1.patch | text/x-diff | 4.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2019-06-10 10:25:57 | Re: BUG #15833: defining a comment on a domain constraint fails with wrong OID |
| Previous Message | Fahar Abbas | 2019-06-10 05:23:38 | Re: BUG #15834: Cannot install npgsql driver |