Re: Confusing error message for REINDEX TABLE CONCURRENTLY

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Ashwin Agrawal <aagrawal(at)pivotal(dot)io>
Cc: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Confusing error message for REINDEX TABLE CONCURRENTLY
Date: 2019-06-05 06:11:13
Message-ID: 20190605061113.GG1580@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jun 04, 2019 at 11:26:44AM -0700, Ashwin Agrawal wrote:
> The variable is used in else scope hence I moved it there. But yes its
> removed completely for this scope.

Thanks for updating the patch. It does its job by having one separate
message for the concurrent and the non-concurrent cases as discussed.
David, what do you think? Perhaps you would like to commit it
yourself?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message tushar 2019-06-05 06:24:49 Re: [pg_rewind] cp: cannot stat ‘pg_wal/RECOVERYHISTORY’: No such file or directory
Previous Message Michael Paquier 2019-06-05 06:03:26 Re: nitpick about poor style in MergeAttributes