psql completion bugs with access methods

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: psql completion bugs with access methods
Date: 2019-06-01 19:10:07
Message-ID: 20190601191007.GC1905@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all,

I have bumped into a couple of issues with psql completion for access
methods:
1) CREATE INDEX USING suggests both index and table AMs.
2) CREATE TABLE USING has no completion support, USING not being
included in the completion, and the follow-up table AMs are missing as
well.
3) CREATE ACCESS METHOD TYPE suggests only INDEX.

Attached is a patch to close the gap. Thoughts?
--
Michael

Attachment Content-Type Size
ams-completion-v1.patch text/x-diff 3.2 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2019-06-01 19:19:43 Re: Custom table AMs need to include heapam.h because of BulkInsertState
Previous Message Michael Paquier 2019-06-01 19:09:46 Table AM callbacks referring to heap in declarations (+typos)