| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org, Peter Eisentraut <peter_e(at)gmx(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: cpluspluscheck vs vpath |
| Date: | 2019-05-30 22:04:07 |
| Message-ID: | 20190530220407.sx37tgh2akonb23d@alap3.anarazel.de |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2019-05-30 15:02:44 -0700, Andres Freund wrote:
> right now cpluspluscheck doesn't work with vpath builds. That's pretty
> annoying, because it does require cloning the git tree into a separate
> directory + doing configure there just to run cpluspluscheck.
>
> Attached is a small patch allowing cpluspluscheck to run from different
> directories. I needs the src and build directories for that,
> unsurprisingly.
>
> As that makes it more complicated to invoke, I added a makefile target
> (in the top level) for it.
>
> Seems we could round the edges a good bit further than what's done in
> the attached (argument checking, for example, but also using the C++
> compiler from configure). But I think this would already be an
> improvement?
Ugh, sent the previous email too early.
Greetings,
Andres Freund
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-integrate-cpluspluscheck-a-bit-more.patch | text/x-diff | 2.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2019-05-30 22:08:29 | Re: cpluspluscheck vs vpath |
| Previous Message | Andres Freund | 2019-05-30 22:02:44 | cpluspluscheck vs vpath |