Dead stores in src/common/sha2.c

From: "Hamlin, Garick L" <ghamlin(at)isc(dot)upenn(dot)edu>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Dead stores in src/common/sha2.c
Date: 2019-05-29 13:24:19
Message-ID: 20190529132415.GA12011@isc.upenn.edu
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I ran clang checker and noticed these. It looks like the
sha2 implementation is trying to zero out state on exit, but
clang checker finds at least 'a' is a dead store.

Should we fix this?
Is something like the attached sensible?
Is there a common/better approach to zero-out in PG ?

Garick

Attachment Content-Type Size
pg-sha2-dead-store.patch text/plain 1.8 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-05-29 14:32:09 Re: Dead stores in src/common/sha2.c
Previous Message Gilles Darold 2019-05-29 12:26:50 Doc fix on information_schema.views