From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Remove page-read callback from XLogReaderState. |
Date: | 2019-05-28 11:45:24 |
Message-ID: | 20190528114524.dvj6ymap2virlzro@alap3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On 2019-04-18 21:02:57 +0900, Kyotaro HORIGUCHI wrote:
> Hello. As mentioned before [1], read_page callback in
> XLogReaderState is a cause of headaches. Adding another
> remote-controlling stuff to xlog readers makes things messier [2].
>
> I refactored XLOG reading functions so that we don't need the
> callback. In short, ReadRecrod now calls XLogPageRead directly
> with the attached patch set.
>
> | while (XLogReadRecord(xlogreader, RecPtr, &record, &errormsg)
> | == XLREAD_NEED_DATA)
> | XLogPageRead(xlogreader, fetching_ckpt, emode, randAccess);
>
> On the other hand, XLogReadRecord became a bit complex. The patch
> makes XLogReadRecord a state machine. I'm not confident that the
> additional complexity is worth doing. Anyway I'll gegister this
> to the next CF.
Just FYI, to me this doesn't clearly enough look like an improvement,
for a change of this size.
Greetings,
Andres Freund
From | Date | Subject | |
---|---|---|---|
Next Message | David Fetter | 2019-05-28 12:40:27 | Re: Add command column to pg_stat_progress_create_index |
Previous Message | Amit Kapila | 2019-05-28 11:26:48 | Re: Fix inconsistencies for v12 |