| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Fujii Masao <fujii(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value. |
| Date: | 2019-05-20 16:36:52 |
| Message-ID: | 20190520163652.l7ibpe52pbq6lecc@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Hi,
On 2019-05-21 01:03:06 +0900, Fujii Masao wrote:
> On Tue, May 21, 2019 at 12:43 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >
> > Fujii Masao <fujii(at)postgresql(dot)org> writes:
> > > Make VACUUM accept 1 and 0 as a boolean value.
> >
> > This was not a particularly great thing to be pushing on a release
> > wrap day, and pushing it without having even run the core regression
> > tests was downright negligent. Please fix or revert, NOW.
>
> Sorry, this is my shameful fault.. Attached is the patch for fix.
> I will commit this after confirming that regression test reports
> no error.
This was 30min ago. I've now pushed test adjustment, so the buildfarm
becomes green again. Still should either add some tests for the change,
or be revert.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2019-05-20 16:43:35 | Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value. |
| Previous Message | Andres Freund | 2019-05-20 16:36:32 | pgsql: Fix regression tests broken in fc7c281f87467. |