Re: New EXPLAIN option: ALL

From: David Fetter <david(at)fetter(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: New EXPLAIN option: ALL
Date: 2019-05-18 18:39:08
Message-ID: 20190518183907.GE28936@fetter.org
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Wed, May 15, 2019 at 09:32:31AM -0400, Tom Lane wrote:
> David Fetter <david(at)fetter(dot)org> writes:
> > I hope the patch is a little easier to digest as now attached.
>
> To be blunt, I find 500K worth of changes in the regression test
> outputs to be absolutely unacceptable, especially when said changes
> are basically worthless from a diagnostic standpoint. There are at
> least two reasons why this won't fly:

Here's a patch set with a much smaller change. Will that fly?

Best,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

Attachment Content-Type Size
v5-0001-Changed-EXPLAIN-ANALYZE-to-EXPLAIN-EXEC.patch text/x-diff 10.6 KB
v5-0002-Documentation.patch text/x-diff 5.6 KB
v5-0003-psql-support.patch text/x-diff 2.2 KB
v5-0004-Examples-in-the-documentation-now-use-EXEC.patch text/x-diff 30.3 KB
v5-0005-Code-comments-now-use-EXPLAIN-EXEC.patch text/x-diff 8.6 KB
v5-0006-Mechanical-changes-in-file_fdw-and-postgres_fdw.patch text/x-diff 2.4 KB
v5-0007-Propagate-changes-to-auto_explain.patch text/x-diff 3.2 KB
v5-0008-Mechanical-changes-to-regression-tests-and-output.patch text/x-diff 42.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2019-05-18 18:49:06 Re: Multivariate MCV stats can leak data to unprivileged users
Previous Message Andrew Dunstan 2019-05-18 15:51:20 Re: How to install login_hook in Postgres 10.5