| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: VACUUM fails to parse 0 and 1 as boolean value |
| Date: | 2019-05-14 23:29:44 |
| Message-ID: | 20190514232944.GC1440@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, May 15, 2019 at 08:20:33AM +0900, Michael Paquier wrote:
> Hmn. I think that Robert's commit is right to rely on defGetBoolean()
> for option parsing. That's what we use for anything from CREATE
> EXTENSION to CREATE SUBSCRIPTION, etc.
And I need more coffee at this time of the day... Because I have not
looked at the proposed patch.
The patch of Fujii-san does its job as far as it goes, but we have
more parsing nodes with the same logic:
- explain_option_arg, which is the same.
- copy_generic_opt_arg, which shares the same root.
So there is room for a common rule, still it does not impact that many
places. I would have believed that more commands use that.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ian Barwick | 2019-05-14 23:50:46 | Re: PG12, PGXS and linking pgfeutils |
| Previous Message | Andres Freund | 2019-05-14 23:26:18 | Re: VACUUM fails to parse 0 and 1 as boolean value |