Re: [PATCH v1] Add a way to supply stdin to TAP tests

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: david(at)fetter(dot)org
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH v1] Add a way to supply stdin to TAP tests
Date: 2019-05-07 02:05:32
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


At Sun, 28 Apr 2019 17:07:16 +0200, David Fetter <david(at)fetter(dot)org> wrote in <20190428150716(dot)GP28936(at)fetter(dot)org>
> Our test coverage needs all the help it can get.
> This patch, extracted from another by Fabian Coelho, helps move things
> in that direction.
> I'd like to argue that it's not a new feature, and that it should be
> back-patched as far as possible.

The comment for the parameter "in".

+# - in: standard input

Perhaps this is "string to be fed to standard input". This also
can be a I/O reference but we don't care that?

+ $in = '' if not defined $in;

run($cmd, '<', \undef) seems to work, maybe assuming "<
/dev/null", which might be better?


Kyotaro Horiguchi
NTT Open Source Software Center

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-05-07 02:23:07 Re: reindexdb & clusterdb broken against pre-7.3 servers
Previous Message Michael Paquier 2019-05-07 01:55:06 Re: Regression test PANICs with master-standby setup on same machine