Re: Add tablespace tap test to pg_rewind

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: michael(at)paquier(dot)xyz
Cc: tgl(at)sss(dot)pgh(dot)pa(dot)us, alvherre(at)2ndquadrant(dot)com, sbai(at)pivotal(dot)io, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Add tablespace tap test to pg_rewind
Date: 2019-05-07 01:31:59
Message-ID: 20190507.103159.136061385.horiguchi.kyotaro@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Sat, 27 Apr 2019 09:35:19 +0900, Michael Paquier <michael(at)paquier(dot)xyz> wrote in <20190427003519(dot)GC2032(at)paquier(dot)xyz>
> On Fri, Apr 26, 2019 at 11:21:48AM -0400, Tom Lane wrote:
> > I don't think feature freeze precludes adding new test cases.
>
> I think as well that adding this stuff into v12 would be fine. Now if
> there is any objection let's wait for later.

The patch seems to be using the tablespace directory in backups
directly from standbys. In other words, multiple standbys created
from A backup shares the tablespace directory in the backup.

Another nitpicking is it sound a bit strainge that the parameter
"has_tablespace_mapping" is not a boolean.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2019-05-07 01:48:40 Re: accounting for memory used for BufFile during hash joins
Previous Message Matsumura, Ryo 2019-05-07 01:30:57 RE: SQL statement PREPARE does not work in ECPG