Re: pg_upgrade --clone error checking

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_upgrade --clone error checking
Date: 2019-05-02 16:28:49
Message-ID: 20190502162849.GA2314@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2019-May-02, Jeff Janes wrote:

> I think the error message wording is OK, I think it should be thrown
> earlier, before the "Creating dump of database schemas" (which can take a
> long time), and preferably before either database is even started. So
> ideally it would be something like:
> Performing Consistency Checks
> -----------------------------
> Checking cluster versions
> Checking file cloning support
> File cloning not supported on this platform
> Failure, exiting
> When something is doomed to fail, we should report the failure as early as
> feasibly detectable.

I agree -- this check should be done before checking the database
contents. Maybe even before "Checking cluster versions".

Álvaro Herrera
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2019-05-02 16:35:57 Re: pgbench - add option to show actual builtin script code
Previous Message Jeff Janes 2019-05-02 16:24:17 Re: pg_upgrade --clone error checking