From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Noah Misch <noah(at)leadboat(dot)com> |
Cc: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: compiler warning in pgcrypto imath.c |
Date: | 2019-05-01 16:18:02 |
Message-ID: | 20190501161802.asarni2ozmht6elc@alap3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi Noah,
On 2019-03-23 00:02:36 -0700, Noah Misch wrote:
> On Sat, Mar 23, 2019 at 10:20:16AM +0900, Michael Paquier wrote:
> > On Fri, Mar 22, 2019 at 08:20:53PM -0400, Jeff Janes wrote:
> > > PostgreSQL 12devel on aarch64-unknown-linux-gnu, compiled by gcc
> > > (Ubuntu/Linaro 7.3.0-27ubuntu1~18.04) 7.3.0, 64-bit
> >
> > Adding Noah in CC as he has done the update of imath lately.
> >
> > > The attached patch adds PG_USED_FOR_ASSERTS_ONLY to silence it. Perhaps
> > > there is a better way, given that we want to change imath.c as little as
> > > possible from its upstream?
> >
> > Maybe others have better ideas, but marking the variable with
> > PG_USED_FOR_ASSERTS_ONLY as you propose seems like the least invasive
> > method of all.
>
> That patch looks good. Thanks. The main alternative would be to pass
> -Wno-unused for this file. Since you're proposing only one instance
> PG_USED_FOR_ASSERTS_ONLY, I favor PG_USED_FOR_ASSERTS_ONLY over -Wno-unused.
This is marked as an open item, owned by you. Could you commit the
patch or otherwise resovle the issue?
Greetings,
Andres Freund
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2019-05-01 16:20:21 | Re: using index or check in ALTER TABLE SET NOT NULL |
Previous Message | Bruce Momjian | 2019-05-01 16:17:45 | Re: Unhappy about API changes in the no-fsm-for-small-rels patch |