Re: Unhappy about API changes in the no-fsm-for-small-rels patch

On Wed, May 1, 2019 at 08:24:25AM -0700, Andres Freund wrote:
> Hi,
>
> On 2019-04-18 14:10:29 -0700, Andres Freund wrote:
> > My compromise suggestion would be to try to give John and Amit ~2 weeks
> > to come up with a cleanup proposal, and then decide whether to 1) revert
> > 2) apply the new patch, 3) decide to live with the warts for 12, and
> > apply the patch in 13. As we would already have a patch, 3) seems like
> > it'd be more tenable than without.
>
> I think decision time has come. My tentative impression is that we're
> not there yet, and should revert the improvements in v12, and apply the
> improved version early in v13. As a second choice, we should live with
> the current approach, if John and Amit "promise" further effort to clean
> this up for v13.

My ignorant opinion is that I have been surprised by the churn caused by
this change, and have therefore questioned the value of it. Frankly,
there has been so much churn I am unclear if it can be easily reverted.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +