| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: doc: improve PG 12 to_timestamp()/to_date() wording |
| Date: | 2019-05-01 00:14:04 |
| Message-ID: | 20190501001403.GN3925@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Apr 30, 2019 at 09:48:14PM +0300, Alexander Korotkov wrote:
> I'd like to add couple of comments from my side.
> > - returns an error because the second template string space is consumed
> > - by the letter <literal>J</literal> in the input string.
> > + returns an error because the second space in the template string consumes
> > + the letter <literal>M</literal> from the input string.
>
> Why <literal>M</literal>? There is no letter "M" is input string.
> The issue here is that we already consumed "J" from "JUN" and trying
> to match "UN" to "MON". So, I think we should live
> <literal>J</literal> here. The rest of this change looks good.
Seems like I confused myself while resolving rebase conflict.
Thanks for checking.
Justin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melanie Plageman | 2019-05-01 00:15:55 | Adding a test for speculative insert abort case |
| Previous Message | Andres Freund | 2019-04-30 23:50:25 | Re: clean up docs for v12 |