Re: Regression test PANICs with master-standby setup on same machine

Hello.

Win32 implement cannot have symbolic link feature as Linux-like
OSes for some restrictions. (Windows 7 and 10 behave differently,
as I heard.)

So the 0002 patch implemnets "fake" symbolic link as mentioned in
its commit message.

Also I fixed 0001 slightly.

regards.

At Thu, 25 Apr 2019 17:08:55 +0900 (Tokyo Standard Time), Kyotaro
HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote in
> Thanks for the suggestions, Tom, Andres. For clarity, as I
> mentioned in the post, I didn't like the getcwd in 0001. The
> reason for the previous patch are:
>
> 1. canonicalize_path doesn't process '/.' and '/..' in the middle
> of a path. That prevents correct checking of directory
> inclusiveness. Actually regression test suffers that.
>
> 2. Simply I missed make_absolute_path..
>
> So, I rewote canonicalize_path to process '.' and '..'s not only
> at the end of a path but all occurrances in a path. This makes
> the strange loop of chdir-getwen useless. But the new
> canonicalize_path is a bit complex.
>
> The modified canonicalize_path works filesystem-access-free so it
> doesn't follow symlinks. Thus it makes a misjudge when two paths
> are in an inclusion relationship after resolving symlinks in the
> paths. But I don't think we don't need to treat such a malicious
> situation.

reagrds.

--
Kyotaro Horiguchi
NTT Open Source Software Center