Re: Why is it OK for dbsize.c to look at relation files directly?

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Why is it OK for dbsize.c to look at relation files directly?
Date: 2019-04-25 00:16:50
Message-ID: 20190425001650.GB8552@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Apr 24, 2019 at 04:09:56PM -0700, Andres Freund wrote:
> I think we should change dbsize.c to call
> RelationGetNumberOfBlocksInFork() for relkinds != TABLE/TOAST/MATVIEW,
> and a new AM callback for those. Probably with the aforementioned
> additional logic of closing smgr references if they weren't open before
> the size computation.
>
> Imo this pretty clearly is v13 work.

Agreed that this is out of 12's scope. Perhaps you should add a TODO
item for that?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2019-04-25 00:18:08 Re: Why is it OK for dbsize.c to look at relation files directly?
Previous Message Tom Lane 2019-04-24 23:27:10 Re: BUG #15672: PostgreSQL 11.1/11.2 crashed after dropping a partition table