Re: [Patch] Check file type before calling AllocateFile() for files out of pg data directory to avoid potential issues (e.g. hang).

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Paul Guo <pguo(at)pivotal(dot)io>
Cc: Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [Patch] Check file type before calling AllocateFile() for files out of pg data directory to avoid potential issues (e.g. hang).
Date: 2019-04-24 12:54:13
Message-ID: 20190424125413.GA27406@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2019-Apr-24, Paul Guo wrote:

> On Wed, Apr 24, 2019 at 12:49 PM Andres Freund <andres(at)anarazel(dot)de> wrote:

> > This seems like a bad idea to me. IMO we want to support using a pipe
> > etc here. If the admin creates a fifo like this without attaching a
> > program it seems like it's their fault.
>
> Oh, I never know this application scenario before. So yes, for this, we
> need to keep the current code logic in copy code.

But the pgstat.c patch seems reasonable to me.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Laurenz Albe 2019-04-24 13:04:47 Re: pgsql: Allow insert and update tuple routing and COPY for foreign table
Previous Message David Rowley 2019-04-24 12:43:31 Re: Optimizer items in the release notes