From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: clean up docs for v12 |
Date: | 2019-04-19 14:43:01 |
Message-ID: | 20190419144301.GK2854@telsasoft.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Thanks for committing those portions.
On Fri, Apr 19, 2019 at 05:00:26PM +0900, Michael Paquier wrote:
> I am particularly referring to patches 0005
> (publications use "a superuser" in error messages as well which could
> be fixed as well?),
I deliberately avoided changing thesee "errhint" messages, since the style
guide indicates that errhint should be a complete sentence.
pryzbyj(at)pryzbyj:~/src/postgres$ git grep 'must be a superuser' |grep errhint
src/backend/commands/event_trigger.c: errhint("The owner of an event trigger must be a superuser.")));
src/backend/commands/foreigncmds.c: errhint("The owner of a foreign-data wrapper must be a superuser.")));
src/backend/commands/publicationcmds.c: errhint("The owner of a FOR ALL TABLES publication must be a superuser.")));
src/backend/commands/subscriptioncmds.c: errhint("The owner of a subscription must be a superuser.")));
Justin
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2019-04-19 16:43:24 | Re: POC: Cleaning up orphaned files using undo logs |
Previous Message | Dilip Kumar | 2019-04-19 10:15:43 | Re: POC: Cleaning up orphaned files using undo logs |