Re: Cleanup/remove/update references to OID column

Hi,

On 2019-04-17 19:42:19 -0500, Justin Pryzby wrote:
> diff --git a/doc/src/sgml/information_schema.sgml b/doc/src/sgml/information_schema.sgml
> index 234a3bb..9c618b1 100644
> --- a/doc/src/sgml/information_schema.sgml
> +++ b/doc/src/sgml/information_schema.sgml
> @@ -1312,8 +1312,8 @@
> <para>
> The view <literal>columns</literal> contains information about all
> table columns (or view columns) in the database. System columns
> - (<literal>ctid</literal>, etc.) are not included. Only those columns are
> - shown that the current user has access to (by way of being the
> + (<literal>ctid</literal>, etc.) are not included. The only columns shown
> + are those to which the current user has access (by way of being the
> owner or having some privilege).
> </para>

I don't see the point of this change? Nor what it has to do with oids?

> diff --git a/doc/src/sgml/ref/insert.sgml b/doc/src/sgml/ref/insert.sgml
> index 189ce2a..f995a76 100644
> --- a/doc/src/sgml/ref/insert.sgml
> +++ b/doc/src/sgml/ref/insert.sgml
> @@ -554,7 +554,7 @@ INSERT <replaceable>oid</replaceable> <replaceable class="parameter">count</repl
> The <replaceable class="parameter">count</replaceable> is the number of
> rows inserted or updated. <replaceable>oid</replaceable> is always 0 (it
> used to be the <acronym>OID</acronym> assigned to the inserted row if
> - <replaceable>rows</replaceable> was exactly one and the target table was
> + <replaceable>count</replaceable> was exactly one and the target table was
> declared <literal>WITH OIDS</literal> and 0 otherwise, but creating a table
> <literal>WITH OIDS</literal> is not supported anymore).
> </para>

The <replacable>rows</<replacable> reference is from your change
:(. I'll fold it into another upcoming change for other tableam comment
improvements (by Heikki).

Greetings,

Andres Freund