Re: Suspicious strcmp() in src/backend/parser/parse_expr.c

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, Rikard Falkeborn <rikard(dot)falkeborn(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>
Subject: Re: Suspicious strcmp() in src/backend/parser/parse_expr.c
Date: 2019-04-12 01:29:54
Message-ID: 20190412012954.GB2144@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Fri, Apr 12, 2019 at 02:06:11AM +1200, David Rowley wrote:
> spell.c in NISortDictionary()
>
> if (i == 0
> || strcmp(Conf->Spell[i]->p.flag, Conf->Spell[i - 1]->p.flag))
>
> if (i == 0
> || strcmp(Conf->Spell[i]->p.flag, Conf->AffixData[curaffix]))

Good catch on these two. I have included these and fixed all the
spots found in d527fda.
--
Michael

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message r.zharkov 2019-04-12 02:44:04 Re: BUG #15727: PANIC: cannot abort transaction 295144144, it was already committed
Previous Message Michael Paquier 2019-04-12 00:58:57 Re: Suspicious strcmp() in src/backend/parser/parse_expr.c