| From: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | hosoya(dot)yuzuko(at)lab(dot)ntt(dot)co(dot)jp |
| Cc: | Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp, thibaut(dot)madelaine(at)dalibo(dot)com, imai(dot)yoshikazu(at)jp(dot)fujitsu(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Problem with default partition pruning |
| Date: | 2019-04-09 01:33:17 |
| Message-ID: | 20190409.103317.20446083.horiguchi.kyotaro@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Sigh..
At Tue, 09 Apr 2019 10:28:48 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote in <20190409(dot)102848(dot)252476604(dot)horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
> As the second thought. Partition constraint is not constraint
> expression so that's fair to apply partqual ignoring
> constraint_exclusion. The variable is set false to skip useless
> expression evaluation on all partitions, but partqual should be
> evaluated just once. Sorry for my confusion.
>
> So still it is wrong that the new code is added in
> gen_partprune_steps_internal.
So still it is wrong that the new code is added at the beginning
of the loop on clauses in gen_partprune_steps_internal.
> If partqual results true and the
> clause is long, the partqual is evaluated uselessly at every
> recursion.
>
> Maybe we should do that when we find that the current clause
> doesn't match part attributes. Specifically just after the for
> loop "for (i = 0 ; i < part_scheme->partnattrs; i++)".
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-04-09 01:38:19 | Re: pg_rewind vs superuser |
| Previous Message | Kyotaro HORIGUCHI | 2019-04-09 01:28:48 | Re: Problem with default partition pruning |