| From: | Shawn Debnath <sdn(at)amazon(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Refactoring the checkpointer's fsync request queue |
| Date: | 2019-04-05 16:22:06 |
| Message-ID: | 20190405162206.GA23763@f01898859afd.ant.amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Apr 05, 2019 at 10:53:53AM +1300, Thomas Munro wrote:
> On Fri, Apr 5, 2019 at 2:03 AM Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> > On 2019-Apr-04, Thomas Munro wrote:
> > > I don't think it's project policy to put a single typedef into its own
> > > header like that, and I'm not sure where else to put it.
> >
> > shrug. Looks fine to me. I suppose if we don't have it anywhere, it's
> > just because we haven't needed that particular trick yet. Creating a
> > file with a lone typedef seems better than using uint32 to me.
>
> It was commit 9fac5fd7 that gave me that idea.
>
> Ok, here is a patch that adds a one-typedef header and uses
> SegmentIndex to replace all cases of BlockNumber and int holding a
> segment number (where as an "index" or a "count").
Looks good to me.
--
Shawn Debnath
Amazon Web Services (AWS)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexis Andrieu | 2019-04-05 16:26:16 | Small typo fix on tableam documentation |
| Previous Message | Arthur Zakirov | 2019-04-05 16:21:31 | Re: [PROPOSAL] Shared Ispell dictionaries |