| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Surafel Temesgen <surafel3000(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Adam Berlin <berlin(dot)ab(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> |
| Subject: | Re: COPY FROM WHEN condition |
| Date: | 2019-04-04 05:20:00 |
| Message-ID: | 20190404052000.hy5agx5fqselprik@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2019-04-03 20:00:09 +1300, David Rowley wrote:
> Oops, I forgot about that one. v4 attached.
I'm pretty happy with this. I'm doing some minor changes (e.g. don't
like the function comment formatting that much, the tableam callback
needs docs, stuff like that), and then I'm going to push it tomorrow.
I'm planning to attribute it to you, me, and Haribabu Kommi.
Oh, btw, is there a reason you're memset(0)'ing multiInsertInfo? Seems
unnecessary, given that in all cases we're using it we're going to do
CopyMultiInsertInfo_Init(). And IME valgrind and the compiler are more
helpful when you don't just default initialize, because then they can
tell when you forgot to initialize a field (say like
CopyMultiInsertInfo_Init not initializing nbuffers).
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shawn Debnath | 2019-04-04 05:41:07 | Re: Refactoring the checkpointer's fsync request queue |
| Previous Message | Amit Langote | 2019-04-04 04:58:12 | Re: Speed up transaction completion faster after many relations are accessed in a transaction |