Re: ToDo: show size of partitioned table

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, mathias(at)brossard(dot)org, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: ToDo: show size of partitioned table
Date: 2019-04-02 19:15:31
Message-ID: 20190402191531.GA23006@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2019-Mar-13, Amit Langote wrote:

> + if (show_indexes)
> + {
> + objects_name = gettext_noop("indexes");
...
> + if (pattern)
> + /* translator: objects_name is "index", "table" */
> + psql_error("Did not find any partitioned %s named \"%s\".\n",
> + object_name,
> + pattern);
...
> + /* translator: objects_name is "indexes", "tables" */
> + appendPQExpBuffer(&title, _("List of partitioned %s"), objects_name);
> +

This stuff doesn't work from a translation standpoint; sentence building
is not allowed. You have to do stuff like:

if (tables)
{
errmsg = gettext_noop("Could not find any partitioned table");
tabletitle = gettext_noop("List of partitioned tables");
}
...
if (pattern)
/* translator: objects_name is "index", "table" */
psql_error(gettext(errmsg), object_name, pattern);
...
appendPQExpBuffer(&title, gettext(tabletitle));

and so on.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2019-04-02 19:25:06 Re: ToDo: show size of partitioned table
Previous Message Erik Rijkers 2019-04-02 18:54:40 Re: [HACKERS] generated columns