Re: pgsql: Report progress of CREATE INDEX operations

On 2019-Apr-02, Andres Freund wrote:

> Note that longfin complains about something different than the output
> files:
>
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=longfin&dt=2019-04-02%2018%3A49%3A03
>
> lmgr.c:882:14: error: variable 'count' is used uninitialized whenever '?:' condition is false [-Werror,-Wsometimes-uninitialized]
> progress ? &count : NULL));
> ^~~~~~~~
> lmgr.c:883:12: note: uninitialized use occurs here
> total += count;
> ^~~~~
> lmgr.c:882:14: note: remove the '?:' if its condition is always true
> progress ? &count : NULL));
> ^~~~~~~~~~~ ~~~~~~~
> lmgr.c:878:14: note: initialize the variable 'count' to silence this warning
> int count;
> ^

Had noticed, thanks. Just pushed a blind fix for that ...

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services