| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Michael Banck <michael(dot)banck(at)credativ(dot)de> |
| Cc: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, coelho(at)cri(dot)ensmp(dot)fr, alvherre(at)2ndquadrant(dot)com, mailings(at)oopsware(dot)de, thomas(dot)munro(at)enterprisedb(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Progress reporting for pg_verify_checksums |
| Date: | 2019-03-23 01:49:34 |
| Message-ID: | 20190323014934.GL20584@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Mar 22, 2019 at 02:23:17PM +0100, Michael Banck wrote:
> The current version prints a newline when it progress reporting is
> toggled off. Do you mean there is a hazard that this happens right when
> we are printing the progress, so end up with a partly garbage line? I
> don't think that'd be so bad to warrant further code complexitiy, after
> all, the user explicitly wanted the progress to stop.
>
> But maybe I am misunderstanding?
The latest patch does not apply because of mainly ed308d7. Could you
send a rebase?
FWIW, I would remove the signal toggling stuff from the patch and keep
the logic simple at this stage. Not having a solution which works on
Windows is perhaps not a strong reason to not include it, but it's a
sign that we could perhaps design something better, and that's
annoying. Personally I think that I would just use --progress all the
time and not use the signaling part at all, my 2c.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2019-03-23 02:30:31 | Re: psql display of foreign keys |
| Previous Message | Michael Paquier | 2019-03-23 01:41:05 | Re: Contribution to Perldoc for TestLib module in Postgres |