| From: | Stephen Frost <sfrost(at)snowman(dot)net> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Regina Obe <r(at)pcorp(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Paul Ramsey <pramsey(at)cleverelephant(dot)ca> |
| Subject: | Re: Compressed TOAST Slicing |
| Date: | 2019-03-18 05:52:14 |
| Message-ID: | 20190318055214.GE6197@tamriel.snowman.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Greetings,
* Andres Freund (andres(at)anarazel(dot)de) wrote:
> On 2019-03-12 14:42:14 +0900, Michael Paquier wrote:
> > On Mon, Mar 11, 2019 at 08:38:56PM +0000, Regina Obe wrote:
> > > I tested on windows mingw64 (as of a week ago) and confirmed the
> > > patch applies cleanly and significantly faster for left, substr
> > > tests than head.
> >
> > int32
> > pglz_decompress(const char *source, int32 slen, char *dest,
> > - int32 rawsize)
> > + int32 rawsize, bool is_slice)
>
> > The performance improvements are nice, but breaking a published API is
> > less nice particularly since some work has been done to make pglz more
> > plugabble (see 60838df9, guess how wrote that).
>
> I don't think that should stop us from breaking the API. You've got to
> do quite low level stuff to need pglz directly, in which case such an
> API change should be the least of your problems between major versions.
Agreed, this is across a major version and I don't think it's an issue
to break the API.
Thanks!
Stephen
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-03-18 06:05:59 | Re: Online verification of checksums |
| Previous Message | Stephen Frost | 2019-03-18 05:47:06 | Re: Online verification of checksums |