| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Michael Banck <michael(dot)banck(at)credativ(dot)de>, Sergei Kornilov <sk(at)zsrv(dot)org> |
| Subject: | Re: Make pg_checksums complain if compiled BLCKSZ and data folder's block size differ |
| Date: | 2019-03-17 09:10:45 |
| Message-ID: | 20190317091045.GC3357@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Mar 16, 2019 at 11:18:17AM +0100, Magnus Hagander wrote:
> BLCKSZ is very much an internal term. The exposed name through pg_settings
> is block_size, so I think the original was better. Combining that one with
> yours into "initialized with block size %d" etc, makes it a lot nicer.
Yes, what Fabien and you say here makes sense.
> The "incompatible with pg_checksums" part may be a bit redundant with the
> commandname at the start as well, as I now realized Fabien pointed out
> downthread. But I would suggest just cutting it and saying "%s: database
> files are incompatible" or maybe "%s: data directory is incompatible" even?
"Cluster" is more consistent with the surroundings. So what about the
attached then?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| checksums-blcksz-error-v2.patch | text/x-diff | 687 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2019-03-17 09:11:32 | Re: Make pg_checksums complain if compiled BLCKSZ and data folder's block size differ |
| Previous Message | Fabien COELHO | 2019-03-17 09:01:20 | Re: Offline enabling/disabling of data checksums |