| From: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp |
| Cc: | peter(dot)eisentraut(at)2ndquadrant(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Fix handling of unlogged tables in FOR ALL TABLES publications |
| Date: | 2019-03-14 07:27:16 |
| Message-ID: | 20190314.162716.103433381.horiguchi.kyotaro@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Thu, 14 Mar 2019 15:31:03 +0900, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote in <26bfa053-3fb2-ad1d-efbb-7c930b41c0fd(at)lab(dot)ntt(dot)co(dot)jp>
> On 2019/03/14 15:03, Kyotaro HORIGUCHI wrote:
> > Is it the right thing that GetRelationPublicationsActions sets
> > wrong rd_publicatons for the relations?
>
> Actually, after applying Peter's patch, maybe we should add an
> Assert(is_publishable_relation(relation)) at the top of
> GetRelationPublicationActions(), also adding a line in the function header
> comment that callers must ensure that. There's only one caller at the
> moment anyway, which Peter's patch is fixing to ensure that.
Yeah, that's a reasnable alternative.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro HORIGUCHI | 2019-03-14 07:32:25 | Re: why doesn't DestroyPartitionDirectory hash_destroy? |
| Previous Message | Matsumura, Ryo | 2019-03-14 07:17:08 | Is PREPARE of ecpglib thread safe? |