| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Regina Obe <r(at)pcorp(dot)us> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Paul Ramsey <pramsey(at)cleverelephant(dot)ca> |
| Subject: | Re: Compressed TOAST Slicing |
| Date: | 2019-03-12 05:42:14 |
| Message-ID: | 20190312054214.GJ13812@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 11, 2019 at 08:38:56PM +0000, Regina Obe wrote:
> I tested on windows mingw64 (as of a week ago) and confirmed the
> patch applies cleanly and significantly faster for left, substr
> tests than head.
int32
pglz_decompress(const char *source, int32 slen, char *dest,
- int32 rawsize)
+ int32 rawsize, bool is_slice)
The performance improvements are nice, but breaking a published API is
less nice particularly since some work has been done to make pglz more
plugabble (see 60838df9, guess how wrote that). Could it be possible
to rework this part please? It's been some time since I touched this
code, but it would be really nice if we don't have an extra parameter,
and just not bypass the sanity checks at the end. Using a parameter
to bypass those checks may cause problems for future callers of it.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey Lepikhov | 2019-03-12 05:59:41 | Re: Suggestions on message transfer among backends |
| Previous Message | Andrey Borodin | 2019-03-12 05:22:45 | Re: Compressed TOAST Slicing |