| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Include GUC's unit, if it has one, in out-of-range error message |
| Date: | 2019-03-11 01:11:14 |
| Message-ID: | 20190311011114.GD1818@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Sun, Mar 10, 2019 at 07:18:20PM +0000, Tom Lane wrote:
> Include GUC's unit, if it has one, in out-of-range error messages.
>
> This should reduce confusion in cases where we've applied a units
> conversion, so that the number being reported (and the quoted range
> limits) are in some other units than what the user gave in the
> setting we're rejecting.
>
> Some of the changes here assume that float GUCs can have units,
> which isn't true just yet, but will be shortly.
It does not seem to have cooled down all animals yet, whelk is
still complaining:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=whelk&dt=2019-03-11%2000%3A41%3A13
-ERROR: -Infinity is outside the valid range for parameter "geqo_selection_bias" (1.5 .. 2)
+ERROR: invalid value for parameter "geqo_selection_bias": "-infinity"
It would be nice if we could avoid an alternate output.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2019-03-11 02:51:21 | Re: pgsql: tableam: introduce table AM infrastructure. |
| Previous Message | Michael Paquier | 2019-03-11 00:40:12 | Re: pgsql: Removed unused variable, openLogOff. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2019-03-11 01:11:41 | Re: Binary upgrade from <12 to 12 creates toast table for partitioned tables |
| Previous Message | Imai, Yoshikazu | 2019-03-11 01:10:11 | RE: speeding up planning with partitions |