Re: Fwd: Add tablespace tap test to pg_rewind

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Shaoqi Bai <sbai(at)pivotal(dot)io>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Fwd: Add tablespace tap test to pg_rewind
Date: 2019-03-09 00:09:24
Message-ID: 20190309000924.GC9266@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Mar 08, 2019 at 09:42:29PM +0800, Shaoqi Bai wrote:
> There is already a databases tap tests in pg_rewind, wonder if there is a
> need for tablespace tap tests in pg_rewind. Attached is a initial
> patch from me.

When working on the first version of pg_rewind for VMware with Heikki,
tablespace support has been added only after, so what you propose is
sensible I think.

+# Run the test in both modes.
+run_test('local');
Small nit: we should test for the remote mode here as well.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2019-03-09 00:18:57 Re: Performance issue in foreign-key-aware join estimation
Previous Message Haribabu Kommi 2019-03-09 00:03:21 Re: Pluggable Storage - Andres's take