Re: PostgreSQL vs SQL/XML Standards

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: Chapman Flack <chap(at)anastigmatix(dot)net>, Markus Winand <markus(dot)winand(at)winand(dot)at>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: PostgreSQL vs SQL/XML Standards
Date: 2019-03-08 18:34:17
Message-ID: 20190308183417.GA4442@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

(I spent some time trying to reproduce the original bug, but was
interrupted for lunch before getting a useful installation. I find it a
bit strange that it doesn't crash in x86_64, mind ...)

On 2019-Mar-08, Pavel Stehule wrote:

> It fixes current issue, but I afraid so these two routines are not
> replaceable. xmlFreeNodeList doesn't release xmlFreeDtd, XML_ATTRIBUTE_NODE
> is not checked.


> Maybe we can call explicitly xmlFreeDoc instead xmlFreeNode
> some like
> if (cur_copy->type == XML_DOCUMENT_NODE)
> xmlFreeDoc((xmlDocPtr) cur_copy);
> else
> xmlFreeNode(cur_copy);
> This looks most correct fix for me. What do you think?

Seems like that should work, yeah ...

Álvaro Herrera
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2019-03-08 18:44:30 Re: PostgreSQL vs SQL/XML Standards
Previous Message Tomas Vondra 2019-03-08 18:27:38 Re: Hash index initial size is too large given NULLs or partial indexes